Skip to content

Add a Stdin Specification #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add a Stdin Specification #586

wants to merge 1 commit into from

Conversation

jfly
Copy link
Collaborator

@jfly jfly commented May 13, 2025

This completes step 1 of
#573 (comment).

jfly
jfly commented May 13, 2025
View reviewed changes
jfly
jfly commented May 13, 2025
View reviewed changes
jfly
jfly commented May 13, 2025
View reviewed changes
@jfly jfly mentioned this pull request May 27, 2025
Open
@jfly jfly mentioned this pull request Jun 13, 2025
Open
@jfly
Copy link
Collaborator Author

jfly commented Jun 24, 2025

@brianmcgee @zimbatm, is there anything I can do to help move this forward?

@brianmcgee
Copy link
Member

It's unclear to me if this documents the current behaviour or the desired behaviour. If it's the desired behaviour, isn't there some work needing to be done in treefmt to support that before we publish a spec?

@jfly jfly marked this pull request as draft June 28, 2025 15:00
@jfly
Copy link
Collaborator Author

jfly commented Jun 28, 2025

If it's the desired behaviour, isn't there some work needing to be done in treefmt to support that before we publish a spec?

Yes, treefmt needs changes to support this. I'm happy to implement that (in this PR or a separate one). I just don't want to put in the effort until I know we like this approach.

@brianmcgee
Copy link
Member

I'll try to put my brain on this in the next few days. Been a busy few weeks 😫

@jfly
Copy link
Collaborator Author

jfly commented Jul 21, 2025

@brianmcgee, friendly ping

brianmcgee
brianmcgee approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@brianmcgee brianmcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with some of your own musings in the comments you'd left. Otherwise, it seems like a sane spec and one which should be easy enough for formatters to follow.

I also like that this is opt-in.

@brianmcgee
Copy link
Member

P.S. Thanks for taking the time to flesh this out, and sorry for taking a while to get around to reviewing this.

@jfly jfly force-pushed the issue-573-stdin-spec branch 4 times, most recently from 8e6e1cb to 5671029 Compare July 21, 2025 22:25
jfly
jfly commented Jul 22, 2025
View reviewed changes
@jfly jfly force-pushed the issue-573-stdin-spec branch from 5671029 to d8276a6 Compare July 22, 2025 20:02
@jfly jfly requested a review from brianmcgee July 22, 2025 20:09
infinisil
infinisil approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfly
Copy link
Collaborator Author

jfly commented Jul 22, 2025

@brianmcgee @zimbatm, I could use another review on this. If we're happy with the state of this, then I'd like to work on the underlying implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@brianmcgee brianmcgee Awaiting requested review from brianmcgee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfly @brianmcgee @infinisil